chore: declare bench frappe-dependencies and carry v1.2.1 bump to develop - #15
Closed
Guru107 wants to merge 2 commits into
Closed
chore: declare bench frappe-dependencies and carry v1.2.1 bump to develop#15Guru107 wants to merge 2 commits into
Guru107 wants to merge 2 commits into
Conversation
v1.2.0 was tagged and then withdrawn: the repo had immutable releases enabled, so deleting the release left an immutable tag that could not be recreated or moved (pushes rejected with GH013, "creations being restricted"). Republish the same work under a fresh version. Bumps __version__ to 1.2.1 — pyproject declares dynamic = ["version"], so flit reads it — and renames the notes to RELEASE_v1.2.1.md with a note on the withdrawal. No code changes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
New modules need the app to declare which Frappe majors it supports. pyproject.toml had no [tool.bench.frappe-dependencies] section, so bench performed no compatibility check at install time and a mismatch would only surface at runtime. Range covers v15 and v16, matching how the app is developed and tested. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[tool.bench.frappe-dependencies]pyproject.tomlhad no[tool.bench.frappe-dependencies]section at all, sobench get-app/bench install-appran no compatibility check — installing against an unsupported Frappe major would surface as a runtime failure rather than an install-time one. New modules need this declared.The range covers v15 and v16, matching how the app is actually developed and tested (both benches are in use; the v1.2.x work was verified on each).
The commented-out
frappe~=15.0.0in[project].dependenciesis left as is — that is a pip dependency deliberately delegated to bench, and a separate mechanism from this section.Also included:
8140577This PR is cut from
release/v1, which was already one commit ahead ofdevelop, so it also carries the v1.2.1 republish —__version__ = "1.2.1"andRELEASE_v1.2.0.md→RELEASE_v1.2.1.md. That bringsdevelopin line with the v1.2.1 release;developcurrently still reads1.2.0.Not included
erpnextis not declared. The app hard-requires ERPNext for the Project and Item doctypes, so a matchingerpnext = ">=15.0.0,<17.0.0"would normally sit alongside. Left out deliberately — onlyfrappewas specified.CLAUDE.mdstill says "Frappe Framework: ~15.0.0 (managed by bench)", which understates the range now that v16 is declared supported.Verification
{'frappe': '>=15.0.0,<17.0.0'}pre-commit run --all-files→ exit 0, including thecheck tomlhook🤖 Generated with Claude Code